Re: [U-Boot] [PATCH] Revert "build: Use filechk rules to create and update u-boot.lds"

On 04/20/2014 09:33 PM, Masahiro Yamada wrote:

This reverts commit a8b993eb81c142a439c24b871a2317f765fe5397.

Commit a8b993eb claims it fixes u-boot.lds rule by replacing $(call if_changed) with $(call filechk).

But the problem had already been fixed by commit 395e60cd a few days before commit a8b993eb was posted.

Bummer. Sorry about that. I didn't see Masahiro's patch.

What is worse is $(call filechk) is too strong to fix the problem and looks weird.

I'm sure I don't understand that critique at all. "Looks weird"?

However, your patch (395e60cdc) is better in that it catches both the regular top-level and the SPL build's load scripts. Mine did not.

jdl