On 03.12.20 10:15, Patrick Delaunay wrote:
I propose this serie to remove the vidconsole work-around, activated with the 2 options VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME and cleanup the associated code in console.c (under #ifdef CONFIG_VIDCONSOLE_AS_LCD)
This options are now obsolete and they was planned to be removed around the end of 2020.
I propose this patchset for v2021.04 even if I don't test this serie on real boards.
I really would like to keep this code for now.
On the tbs2910 board this workaround was introduced in the last u-boot release (v2020.10), so there was almost no time for end users to notice the warning and to update there environment. Not every end user installs every new u-boot release, so we really should give more time for this change.
This workaround is self-contained, small, easy to maintain, and strictly opt-in. So this workaround hurts nobody, but removing this will let users alone without any HDMI output. So on this board (without included serial console port), this will result in unhappy users, especially since without any console output there is no chance to get any idea what is going wrong.
Thanks, Soeren
Patrick.
Patrick Delaunay (6): tbs2910: configs: remove VIDCONSOLE_AS_LCD peach-pit: configs: remove VIDCONSOLE_AS_LCD snow: configs: remove VIDCONSOLE_AS_LCD peach-pi: configs: remove VIDCONSOLE_AS_LCD spring: configs: remove VIDCONSOLE_AS_LCD video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
common/console.c | 10 ---------- configs/peach-pi_defconfig | 1 - configs/peach-pit_defconfig | 1 - configs/snow_defconfig | 1 - configs/spring_defconfig | 1 - configs/tbs2910_defconfig | 1 - drivers/video/Kconfig | 22 ---------------------- 7 files changed, 37 deletions(-)