
11 Apr
2009
11 Apr
'09
9:11 p.m.
Dear Marco,
In message 49E05B72.602@gmail.com you wrote:
Changelog from v4:
- Added flash_bad_block() function.
- Added a README file.
- Replaced <sys/user.h> with <asm/page.h>
Signed-off-by: Marco Stornelli marco.stornelli@gmail.com
You get your patches wrong.
The commit message (i. e. a description of the patch that explains wht it is good for, goes above your Signed-off-by: line message. What you have there is unusable.
The text you added there must go as a comment, i. e. below the "---" line following your Signed-off-by: line.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
It's a small world, but I wouldn't want to paint it.