Hi Mike,
On Sat, Sep 17, 2011 at 5:20 PM, Mike Frysinger vapier@gentoo.org wrote:
On Saturday, September 17, 2011 12:48:52 Simon Glass wrote:
--- a/arch/sandbox/config.mk +++ b/arch/sandbox/config.mk
-PLATFORM_CPPFLAGS += -DCONFIG_SANDBOX -D__SANDBOX__ +PLATFORM_CPPFLAGS += -DCONFIG_SANDBOX -D__SANDBOX__ -I/usr/include
since this gets used by all u-boot files, shouldnt the /usr/include path get added only for specific files/dirs ? the ones that glue the u-boot world to the host C library ?
Yes I tried to do that, but it didn't seem to work. I have put my original attempt - what I would like to do - in the v2 patch series. I will come back to this later but hopefully someone can just point out what is wrong.
--- /dev/null +++ b/board/sandbox/common/Makefile
+clean:
- rm -f $(SOBJS) $(OBJS)
+distclean: clean
- rm -f $(LIB) core *.bak $(obj).depend
these dont get used, so punt them
--- /dev/null +++ b/board/sandbox/common/os.c
isnt this an "arch" issue and not "board" ?
--- /dev/null +++ b/include/os.h
seems like this glue should be in the sandbox arch subdir -mike
I originally had it there, and then decided to move it since I was concerned that we might want to define an os layer which doesn't do OS calls, but perhaps communicates over a network link to a remote test controller, or uses expect scripts to run tests. However, this is pie in the sky at this stage so I am changing back to arch, as you suggest.
Regards, Simon