On 20.03.19 09:06, Eugen.Hristev@microchip.com wrote:
<snip>
So my question: is the behavior of CONFIG_SPL_WATCHDOG_SUPPORT=n not aligned with your use case ? So you are actually fixing the behavior of CONFIG_SPL_WATCHDOG_SUPPORT=n ?
Yes. Without this patch I do get this build error:
... LD spl/u-boot-spl lib/built-in.o: In function `udelay': /home/stefan/git/u-boot/u-boot/lib/time.c:167: undefined reference to `watchdog_reset' drivers/built-in.o: In function `atmel_nand_pmecc_write_page': /home/stefan/git/u-boot/u-boot/drivers/mtd/nand/raw/atmel_nand.c:592: undefined reference to `watchdog_reset' drivers/built-in.o: In function `atmel_nand_pmecc_read_page': /home/stefan/git/u-boot/u-boot/drivers/mtd/nand/raw/atmel_nand.c:552: undefined reference to `watchdog_reset' drivers/built-in.o: In function `pmecc_err_location': /home/stefan/git/u-boot/u-boot/drivers/mtd/nand/raw/atmel_nand.c:416: undefined reference to `watchdog_reset' scripts/Makefile.spl:384: recipe for target 'spl/u-boot-spl' failed make[1]: *** [spl/u-boot-spl] Error 1 Makefile:1651: recipe for target 'spl/u-boot-spl' failed make: *** [spl/u-boot-spl] Error 2
OK so that's what I want to settle: you are actually fixing the issue of CONFIG_SPL_WATCHDOG_SUPPORT=n not working properly
Yes, its *not* a AT91 specific issue. Its a general issue of the code.
Also, we may have to look inside the atmel_nand.c as it may be affected?
Affected in which way? You mean that the watchdog might time out while loading the main U-Boot proper from NAND? Or what are you referring to?
Thanks, Stefan