hi Wolfgang, We shifted some IRQ specific code (which is more board specific) to the platform.S file. The watchdog reset code was already there in platform.S file, so just removed the duplicate code from start.S :). This makes the cpu specific file more usable for other boards based on arm926. regards -kshitij
-----Original Message----- From: u-boot-users-admin@lists.sourceforge.net [mailto:u-boot-users-admin@lists.sourceforge.net]On Behalf Of Wolfgang Denk Sent: Tuesday, February 24, 2004 4:53 AM To: Rahul Shanbhag Cc: u-boot-users@lists.sourceforge.net Subject: Re: [U-Boot-Users] patch for OMAP1610 board
Dear Rahul,
in message 000001c3f6bc$85c39da0$0953579d@a0875497 you wrote:
I am submitting a patch for u-boot on 1610 innovator with some corrections in start.S file(arm926ejs cpu) and platform.S file (1610 innovator board). This patch moves some board specific initializations from the cpu specific file to the board specific file.
I see that you not only shift code, but also removed the code to disable the watchdog. Is this intentionally? Shouldn't we keep this part of the code somewhere, at least when CONFIG_WATCHDOG is not defined?
Best regards,
Wolfgang Denk