On Sat, Sep 12, 2009 at 10:33 AM, Paulraj, Sandeep s-paulraj@ti.com wrote:
Olof Johansson wrote:
Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp.
Based on the omap3 evm code. I added a new highlevel define for Tobi to avoid having it dependent on CMD_NET (which would seem backward in this case).
Signed-off-by: Olof Johansson olof@lixom.net
Acked-by: Dirk Behme dirk.behme@googlemail.com
Pushed to u-boot-ti
Thanks!
Random question on u-boot development process: I see you didn't add your signed-off on the commit. People don't do that when they check in patches to the u-boot trees?
-Olof
Well look at these 2 examples. Both are my patches, one of them applied by Ben Warren and one by Jean-Christophe
http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commitdiff;h=b3af1d698b031e721b...
The above has a signed-off by Ben
But the below committed by Jean-Christophe does not have his signed-off-by
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=fcaac589a68115819ddadcf5c18d...
I always use 'git am -s', which adds the SOB. My understanding is that
maintainers should do this as an indication of approval and help in traceability.
regards, Ben