Hi Igor,
I tried to apply this to master and send a PR, but unfortunately it needs rebasing. Can you rebase it and resend it?
Thanks /Ilias On Wed, Mar 27, 2024 at 04:17:09PM +0200, Ilias Apalodimas wrote:
Hi Igor,
On Wed, 27 Mar 2024 at 14:13, Igor Opaniuk igor.opaniuk@gmail.com wrote:
Ilias,
On Mon, Mar 4, 2024 at 6:45 PM Igor Opaniuk igor.opaniuk@gmail.com wrote:
- Address some spelling errors and typos
- Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
- Remove common.h inclusion for drivers/tee
- Add calls for closing tee session after every read/write operation.
CI build: [1] https://dev.azure.com/igoropaniuk/u-boot/_build/results?buildId=28&view=...
Changes in v3:
- Added calls for closing tee session after every read/write operation
Changes in v2:
- Fixed chimp_optee.c:37:9: error: implicit declaration of function 'memset'
- Applied R-b and T-b tags
Igor Opaniuk (6): tee: optee: fix description in Kconfig tee: sandbox: fix spelling errors cmd: optee_rpmb: close tee session cmd: optee_rpmb: build cmd for sandbox test: py: add optee_rpmb tests tee: remove common.h inclusion
cmd/Kconfig | 4 +++- cmd/optee_rpmb.c | 23 +++++++++++++++++------ drivers/tee/broadcom/chimp_optee.c | 3 ++- drivers/tee/optee/Kconfig | 2 +- drivers/tee/optee/core.c | 1 - drivers/tee/optee/i2c.c | 1 - drivers/tee/optee/rpmb.c | 1 - drivers/tee/optee/supplicant.c | 2 +- drivers/tee/sandbox.c | 10 +++++----- drivers/tee/tee-uclass.c | 1 - test/py/tests/test_optee_rpmb.py | 20 ++++++++++++++++++++ 11 files changed, 49 insertions(+), 19 deletions(-) create mode 100644 test/py/tests/test_optee_rpmb.py
-- 2.34.1
Are there currently any comments/objections that can prevent these cosmetic changes from being applied? CI is happy now and all tests are passing successfully.
If there are any - just let me know, thanks
IIRC I did run this version on the CI and everything looked fine. I'll send a PR to Tom with it -- apologies for the delay
Regards /Ilias
Regards, Igor
-- Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mailto: igor.opaniuk@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk