On 16 July 2015 at 10:34, Simon Glass sjg@chromium.org wrote:
On 16 July 2015 at 07:26, Linus Walleij linus.walleij@linaro.org wrote:
On Fri, Jul 10, 2015 at 6:18 PM, Sudeep Holla sudeep.holla@arm.com wrote:
Commit 90fbee3e4051 ("cmd_fdt: Actually fix fdt command in sandbox") changed the format(from hex address to unsigned long) in which "fdtaddr" is saved . However do_fdt continues reads the "fdtaddr" assuming it to be in hex format. This may lead to fdt being either loaded or attempted to load at erroneous address generating fault if the address is out of memory.
This patch changes back the format to hex while saving the "fdtaddr" as it was done before.
Signed-off-by: Sudeep Holla sudeep.holla@arm.com Cc: Linus Walleij linus.walleij@linaro.org Cc: Tom Rini trini@konsulko.com Cc: Simon Glass sjg@chromium.org Cc: Hua Yanghao huayanghao@gmail.com Cc: Heiko Schocher hs@denx.de
Looks like the right fix: Acked-by: Linus Walleij linus.walleij@linaro.org
Yours, Linus Walleij
Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot-fdt, thanks!