Stefano Babic wrote:
On 07/04/2011 01:06 PM, Torsten Koschorrek wrote:
This patch fixes compiler errors due to missing definitions of CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR. It also does some cleanup: CONFIG_SYS_TEXT_BASE was moved to scb9328.h, obsolete config.mk was removed. The scb9328 board has 1 DRAM bank, so don't ask for more banks. CONFIG_NR_DRAM_BANKS will ever be 1.
Signed-off-by: Torsten Koschorrekkoschorrek@synertronixx.de
Torsten,
checkpatch reports a couple of errors and your patch seems corrupted. Have you used "git send-email" to post your patch ?
I used git format-patch plus mozilla/iceape. Hmm, maybe I choose another mailer for sending patches the next time...
WARNING: space prohibited between function name and open parenthesis '(' #60: FILE: board/scb9328/scb9328.c:48: +void dram_init_banksize (void)
fixed in v3
ERROR: patch seems to be corrupt (line wrapped?) #80: FILE: board/scb9328/scb9328.c:53: diff --git a/include/configs/scb9328.h b/include/configs/scb9328.h
hopefully ok in v3, this most probably came from mozilla
ERROR: Macros with complex values should be enclosed in parenthesis #90: FILE: board/scb9328/scb9328.c:131: +#define CONFIG_SYS_INIT_SP_ADDR SCB9328_SDRAM_1 + 0xf00000
fixed in v3
Best regards, Stefano Babic
Torsten