Hi Simon,
I read your initial comments, and I immediately realized I made a mistake. I had initially submitted my series on a local branch, but my mailing client didn't send out anything past the cover letter. (I think Patman had CC'd too many people, and my mailer was preventing spam) When you first responded, I then rushed out the patch again, trimming down what Patman was trying to do. I was on a different branch and had made a couple small efforts towards refactoring. On that branch, I had intended to submit commits A, B, and C, but instead, sent you C, D, and E.
Commit A will have the tests I added to the test runner. Commit B will have some of the missing documentation you had mentioned. And you responded favorably to Commit D.
I will submit a new patch series with the correct commits (A, B, C, and D), with modifications based on your review comments. I will not be pursuing a larger refactor at this time.
Thank you, and I apologize for any confusion I may have caused.
On 05/13/2015 08:53 AM, Karl Apsite wrote:
The FIT config now supports a tag named "loadables:" which is a comma separated list. Users can add any number of images to the list, and u-boot will move the selected binaries to their listed load_addresses. This allows u-boot to boot xen from using an FIT configuration. Xen expects a kernel to be placed at a predetermined location, however the "kernel" field was already filled by xen itself. This change allows the user to move the required binary before xen boots, all within the FIT's configuration.
Karl Apsite (3): add boot_get_loadables() to load listed images Combine bootm_find_<thing> functions together Remove the bootm_find_other() wrapper
common/bootm.c | 50 ++++++++++------------------ common/cmd_bootm.c | 4 +-- common/image-fit.c | 8 ++++- common/image.c | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/bootm.h | 2 +- include/bootstage.h | 1 + include/image.h | 5 ++- 7 files changed, 125 insertions(+), 38 deletions(-)