On 03/05/2014 12:57 AM, Chin Liang See wrote:
On Fri, 2014-02-28 at 11:37 +0100, Michal Simek wrote:
+/* lld_nand.h */ +/*
- NAND Flash Controller Device Driver
- Copyright (c) 2009, Intel Corporation and its suppliers.
- This program is free software; you can redistribute it and/or modify it
- under the terms and conditions of the GNU General Public License,
- version 2, as published by the Free Software Foundation.
- This program is distributed in the hope it will be useful, but WITHOUT
- ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- more details.
- You should have received a copy of the GNU General Public License along with
- this program; if not, write to the Free Software Foundation, Inc.,
- 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
Isn't this pretty weird if we are using SPDX?
I believe the Linux driver owner wish to maintain this header when he/she copy into NAND driver. Anyhow, the SPDX license already stated at top of the header file.
- Using address in license is just wrong and it should be removed
because they can move to different location.
- u-boot adopted SPDX and all these fragments were removed.
Wolfgang/Tom: IMHO this should be also changed/fixed.
Just check the latest denali.h in Linux and this license header still there. But removing the license header put by original author might not a good thing to do. Unless we can get some approval from Wolfgang or Jason (who is submitter of this file to Linux).
ok then what have you done with license on the top of drivers/mtd/nand/denali.h? You have changed it to SPDX license. Have you asked them to change it too?
That file already has license it it and the second license is just compatible with the first one that's why IMHO you can just remove it.
Thanks, Michal