18 May
2022
18 May
'22
4:33 p.m.
On Wed, May 11, 2022 at 05:20:02PM -0700, Tim Harvey wrote:
Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches.
Cc: Marek BehĂșn marek.behun@nic.cz Cc: Vladimir Oltean vladimir.oltean@nxp.com Signed-off-by: Tim Harvey tharvey@gateworks.com
v2:
- rebase on v2022.07-rc1 (use ofnode_get_phy_node)
- remove unused commented out fields from struct
- remove unused PORT_MASK macro
- remove phy from priv struct name
- refactor code from original drivers/net/phy/mv88e61xx with suggestions from review to consolidate some functions into mv88e61xx_dsa_port_enable
- remove unecessary skiping of disabling of CPU port
- remove unecessary dev_set_parent_priv
- remove unnecessary static init flag
- replace debug with a dev_warn if switch device-id unsupported
- remove unnecessary xmit/recv functions as we rely on the fact that only a single port is active instead of mangling packets
Some may prefer the driver be named mv88e6xxx, for more perceived similarity with Linux.
That can be done later anyway. Thanks for the submission, IMO it looks good enough and is certainly a great start.
Reviewed-by: Vladimir Oltean vladimir.oltean@nxp.com