Hi Ajay,
On 03/05/2014 07:06 AM, Ajay kumar wrote:
Piotr,
Sorry for late reply. Can you change the name of exynos_lcd_panel_init to exynos_lcd_misc_init. panel_init definitely gives a wrong meaning.
Yes, I can.
And, can you let me know where you are actually using "panel_info.resolution"? Is it needed for FIMD or is it needed by MIPI-DSI? If it is MIPI specific, then it should come as a DT entry from MIPI-DSI node.
Well, it looks like it is not used any more. I will remove it completely.
Also, if you add a new DT entry, please update the following file: doc/device-tree-bindings/video/exynos-fb.txt
Ok.
Regards, Ajay Kumar
Best regards, Piotr Wilczek
On Tue, Mar 4, 2014 at 7:25 PM, Piotr Wilczek p.wilczek@samsung.com wrote:
This patch adds additional data parsing from DTB and adds the new exynos_lcd_panel_init() function for panel specific initialisation from the board file.
Signed-off-by: Piotr Wilczek p.wilczek@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com Cc: Minkyu Kang mk7.kang@samsung.com
Changes for v4:
- remove duplicated DT properties at exynos_fb.c file
Changes for v3:
- none
Changes for v2:
- removed duplicate DTB node parsing for panel_info.logo_on
- added (weak) exynos_lcd_panel_init function for panel specific initialisation from board file
drivers/video/exynos_fb.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c index 00a0a11..77a3186 100644 --- a/drivers/video/exynos_fb.c +++ b/drivers/video/exynos_fb.c @@ -104,6 +104,13 @@ void __exynos_backlight_reset(void) void exynos_backlight_reset(void) __attribute__((weak, alias("__exynos_backlight_reset")));
+int __exynos_lcd_panel_init(vidinfo_t *vid) +{
return 0;+} +int exynos_lcd_panel_init(vidinfo_t *vid)
__attribute__((weak, alias("__exynos_lcd_panel_init")));- static void lcd_panel_on(vidinfo_t *vid) { udelay(vid->init_delay);
@@ -269,6 +276,9 @@ int exynos_fimd_parse_dt(const void *blob) panel_info.dual_lcd_enabled = fdtdec_get_int(blob, node,
"samsung,dual-lcd-enabled", 0);
panel_info.resolution = fdtdec_get_int(blob, node,"samsung,resolution", 0);return 0;@@ -281,10 +291,15 @@ void lcd_ctrl_init(void *lcdbase) #ifdef CONFIG_OF_CONTROL if (exynos_fimd_parse_dt(gd->fdt_blob)) debug("Can't get proper panel info\n"); +#ifdef CONFIG_EXYNOS_MIPI_DSIM
exynos_init_dsim_platform_data(&panel_info);+#endif
exynos_lcd_panel_init(&panel_info);panel_width = panel_info.vl_width; panel_height = panel_info.vl_height;-- 1.8.3.2
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot