Dear Ilya,
In message 1241634633-13917-1-git-send-email-yanok@emcraft.com you wrote:
This patch set adds support for LogicPD i.MX27-LITEKIT development board. It contains support for i.MX27 CPU, support for serial console, FEC ethernet controller, NFC NAND controller and SDHC controller. It also contains some fixes to generic MMC subsystem.
Signed-off-by: Ilya Yanok yanok@emcraft.com
General comments in addition to what the other posters already remarked:
The whole patch set needs clean up regarding coding style: line length, indentation and vertical alignment by TABs, brace style, no C++ comments, incorrect multiline comment style, etc.
Also, large parts of the code are based on accessing device registers through pointers, usualy hiddewn in some macros using base address and offset. We don't accept such code any more. Please use C structs and I/O accessor calls.
Best regards,
Wolfgang Denk