Hi Wolfgang,
On Wed, Dec 28, 2011 at 9:30 AM, Wolfgang Denk wd@denx.de wrote:
Dear Simon,
In message 1325054160-24894-1-git-send-email-sjg@chromium.org you wrote:
This series creates a generic board.c implementation which contains the essential functions of the various arch/xxx/lib/board.c files.
I'll be loking into this deeper when I'm back at work (i. e. starting with week 2 next year), but I'd like to make this comment as early as possible:
When making such changes, I _strongly_ recommend to use the Power architecture implementation as reference. There are a number of reasons for this, which I don't intend to explain in detail here and now (lack of time). But PPC is the most complete, longest living and most thoroughly designed architecture. Things that other architectures aquire only over time (relocation, cache support, FDT support, multiple busses [I2C, PCI, ...]) have "always" been supported by PPC.
I fear that unifying any architectures and not including PPC rightr from the beginning will result in additional efforts later, so please have a look is this can be changed.
Thanks.
Yes that has been in the back of my mind. I have had a look through this but have not started a serious effort on it. There are quite a few extra bits. My main concern is that I cannot test PPC, but I will see if I can put together a patch in any case.
Regards, Simon
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Cigarette, n.: A fire at one end, a fool at the other, and a bit of tobacco in between.