On 06/17/2013 02:56:45 AM, Zhang Ying-B40530 wrote:
-----Original Message----- From: Wood Scott-B07421 Sent: Saturday, June 15, 2013 12:37 AM To: Zhang Ying-B40530 Cc: Wood Scott-B07421; u-boot@lists.denx.de; afleming@gmail.com; Xie Xiaobo-R63061 Subject: Re: [PATCH] powerpc/p1022ds: nand: introduce the TPL based on the SPL
On 06/14/2013 05:08:49 AM, Zhang Ying-B40530 wrote:
-----Original Message----- From: Wood Scott-B07421 Sent: Friday, June 14, 2013 5:50 AM To: Zhang Ying-B40530 Cc: Wood Scott-B07421; u-boot@lists.denx.de; afleming@gmail.com; Xie Xiaobo-R63061 Subject: Re: [PATCH] powerpc/p1022ds: nand: introduce the TPL based on the SPL
Treat the autoconf.mk patch as a dependency. Don't try to hack
around
its absence. [Zhang Ying] According to what you said, the same set of symbols will be declared under different ifdefs. That's the trouble, "The same set of symbols declared under
different
ifdefs" will not be effective in the "Makefile", in the current
case.
It *will* be effective in the makefile if there is a separate autoconf.mk for each phase. My point is that a separate autoconf.mk for each phase is a requirement for TPL to be done in a sane way. [Zhang Ying] So, could you tell me where I do wrong? Please let me know the specific. Thanks.
Do not create a whole bunch of CONFIG_TPL_... definitions. Base your patches on top of the patch that creates a separate autoconf.mk.
-Scott