Re: [U-Boot] [PATCH 4/6] mxs: mmc: Allow overriding default card detect implementation

On 24/01/2013 19:34, Marek Vasut wrote:

...

That's also an option ... do you want subsequent patch or respin of the series?

Actually, check how it's distributed:

$ git grep mxsmmc_initialize board | sed "s@.*/@@" apx4devkit.c: return mxsmmc_initialize(bis, 0, NULL, NULL); m28evk.c: return mxsmmc_initialize(bis, 0, m28_mmc_wp, NULL); mx28evk.c: return mxsmmc_initialize(bis, 0, mx28evk_mmc_wp, NULL); mx23_olinuxino.c: return mxsmmc_initialize(bis, 0, NULL, mx23_olx_mmc_cd); sc_sps_1.c: return mxsmmc_initialize(bis, 0, NULL, NULL);

We have quite a bit of variance there. I wonder if using cpu_mmc_init() is worth it.

I see. Ok, then let's the things as they are.

Regards, Stefano Babic