Hello Wolfgang,
On 23.09.2011 09:06, Wolfgang Denk wrote:
Dear Andy Fleming,
In messageCAKWjMd5HGT9df76vPFs8B5sFQYWoAN1bGmt2vRihN0cTa1boug@mail.gmail.com you wrote:
Shoot, I just saw this patch in my tree. It's incorrect.
Argh...
The lines weren't redundant. The logic is (and probably should be better commented):
Find the intersection of the advertised capabilities of both sides of the link (lpa) From that intersection, find the highest capability we can run at (that will be the negotiated link)
Now imagine that the intersection (lpa) is (LPA_100HALF | LPA_10FULL).
The code will now set phydev->speed to 100, and phydev->duplex to 1, but this link does not support 100FULL.
Do we agree that I should revert this commit?
due to Andy's explanation I agree that this change is fishy and it should be reverted.
As a U-Boot user I'd greatly appreciate, if you add the above note to the commit message.
Sorry for inconvenience.