Hi Heinrich,
On Sun, 5 Feb 2023 at 14:15, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Am 5. Februar 2023 20:46:16 MEZ schrieb Simon Glass sjg@chromium.org:
This does not work on some 64-bit machines since only a 32-bit address for the framebuffer is supported in the VESA structure.
"This" requires some preceding sentence. Please, describe what problem you want to solve.
This refers to the subject: video: efi: Improve the EFI-app video console
If that is the only comment, I can resend the series with that change?
Regards, Simon
Best regards
Heinrich
This series corrects this and makes a few other minor, video-related improvements.
Simon Glass (11): efi: video: Move payload code into a function efi: video: Return mode info for app also efi: Support a 64-bit frame buffer address x86: Add a few more items to bdinfo efi: Use a fixed value for the timer clock efi: Support copy framebuffer video: Allow a copy framebuffer with pre-allocated fb video: Remove duplicate cursor-positioning function video: Clear the vidconsole rather than the video efi: Add dhrystone, dcache and scroll lines to app video: Add a note about the broken implementation
arch/x86/dts/efi-x86_app.dts | 1 + arch/x86/lib/bdinfo.c | 4 + arch/x86/lib/fsp/fsp_graphics.c | 2 +- cmd/cls.c | 20 +++-- configs/efi-x86_app64_defconfig | 3 + drivers/pci/pci_rom.c | 10 ++- drivers/timer/tsc_timer.c | 4 + drivers/video/coreboot.c | 2 +- drivers/video/efi.c | 125 +++++++++++++++++++++--------- drivers/video/vidconsole-uclass.c | 48 +++++------- drivers/video/video-uclass.c | 32 ++++++-- include/vesa.h | 16 +++- include/video.h | 2 + include/video_console.h | 9 +++ 14 files changed, 193 insertions(+), 85 deletions(-)