Re: [PATCH v2 10/10] rockchip: gpio: Add missing gpio aliases

Hi Jonas,

On 8/3/24 12:56 AM, Jonas Karlman wrote:

Add aliases for gpio controllers to soc u-boot dtsi files that are missing aliases in soc dtsi files to ensure dev_seq() return the expected number when a gpio controller is included in SPL.

Also drop the aliases from rk3288-u-boot.dtsi, they are already part of rk3288.dtsi.

I know that dt-bindings folks usually complain about those aliases in dtsi, but for Rockchip Heiko merges those usually, c.f. RK3399 for example. So I would suggest to send those patches upstream so we don't keep those forever in U-Boot?

The changes themselves look good to me though.

Cheers, Quentin