In message EFB813091B18D511BD3600508B644F8214B8E2EC@tx14exm06.ftw.mot.com you wrote:
The attached patch adds I2C2 support for the MPC8548CDS board. I've performed a limited testing on our MPC8548CDS board and everything seems to be working fine.
I reject the patch. There are a couple of formal reasons that alone would justify such a decision (like missing CHANGELOG entry, violations of Coding Style, etc.), but the main reason is that you don't add just some board specific code, but instead you heavily modify common code (common/cmd_i2c.c) with board or processor specific (#ifdef CONFIG_MPC8548) stuff. And you don't even mention this in your description!
I will not accept any board or processor specific code in common files like common/cmd_i2c.c.
Best regards,
Wolfgang Denk