On 11/28/11 17:15, Wolfgang Denk wrote:
Dear Igor Grinberg,
In message 4ED34E9B.7040200@compulab.co.il you wrote:
Hm... the fix seems wrong to me. What happens now if ENV_IS_EMBEDDED is set, but CONFIG_BUILD_ENVCRC is _not_ set?
Well, you should look into that file...
It's faster for me to ask you to do that :-)
I have already done that (before sending the patch) as soon as I saw the email from Mike, reporting the problem.
Did this change pass a MAKEALL for example for ppc?
I don't have the tool chain for ppc. I think the original fix has been tested by Stefano. Is there a requirement to have all the supported architectures tool chains, for submitting patches?
Not for all, but http://www.denx.de/wiki/U-Boot/Patches says "Please also run MAKEALL for _at_least_one_other_architecture_ than the one you made your modifications in."
10x for looking into that for me ;-)