On Wed, Oct 28, 2009 at 03:27:26AM -0400, Mike Frysinger wrote:
On Tuesday 27 October 2009 15:34:10 Scott Wood wrote:
On Mon, Oct 26, 2009 at 07:57:50PM -0400, Mike Frysinger wrote:
perhaps it would make more sense to create a HOSTCOMPILE/HOSTLINK (or whatever) variable so this kind of thing isnt missed ? HOSTCOMPILE = $(HOSTCC) $(HOSTCFLAGS) HOSTLINK = $(HOSTCOMPILE) $(HOSTLDFLAGS)
Maybe. What about PEDCFLAGS? Should that be the default for HOSTCOMPILE, and then have a HOSTCOMPILENOPED?
i think the intention was to build everything with -pedantic. so add it to the default flags and drop the distinction completely. it'd make the resulting build code a lot simpler.
We can't build everything with it, as we have a lot of code that is incompatible. There were already exceptions in the makefiles for these files. Fixing that code is beyond the scope of this change, especially for code like libfdt that has an external upstream.
I'd be OK with removing -pedantic from everything, if Wolfgang agrees.
I was expecting it to be built by adding easylogo to TOOLSUBDIRS (it would be better if there were a distinct make target for it, but that's another patch). Other tools such as gdb already assume they're being run in this manner.
where does TOOLSUBDIRS get changed ? i dont see any place in u-boot where it is set and your patch doesnt change that from what i can see.
On the command line (or by editing the makefile), apparently. It's not great, but again, changing that is outside the scope of this change.
-Scott