Re: [U-Boot] [PATCH 4/7] ahci: move link bring-up handling to separate function

On Tue, May 21, 2013 at 05:44:33PM -0500, Rob Herring wrote:

From: Rob Herring rob.herring@calxeda.com

Move the link bring-up handling to a separate weak function in order to allow platforms to override it. This is needed on highbank platform which needs special phy handling.

Signed-off-by: Rob Herring rob.herring@calxeda.com

[snip]

+static int __ahci_link_up(struct ahci_probe_ent *probe_ent, u8 port) +{

• u32 tmp;
• int j = 0;
• u8 *port_mmio = (u8 *)probe_ent->port[port].port_mmio;
• /* Bring up SATA link.

/* * Like this */

+int ahci_link_up(struct ahci_probe_ent *probe_ent, u8 port)

• __attribute__((weak, alias("__ahci_link_up")));

Just use __weak please, thanks.