Re: [U-Boot] [PATCH v1 3/3] mxs: Convert sys_proto.h prefixes to 'mxs'

13 Aug 2012

Dear Otavio Salvador,
...
On Mon, Aug 13, 2012 at 3:11 PM, Marek Vasut marex@denx.de wrote:
...
Dear Otavio Salvador,
[...]
...

diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c index 84d4a17..ddafddb 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
@@ -82,9 +82,9 @@ uint8_t mxs_get_bootmode_index(void)
  bootmode |= (gpio_get_value(MX28_PAD_LCD_D04__GPIO_1_4) ? 1 : 0)
  << 4; bootmode |= (gpio_get_value(MX28_PAD_LCD_D05__GPIO_1_5) ? 1
  : 0) << 5;



for (i = 0; i < ARRAY_SIZE(mx28_boot_modes); i++) {


        masked = bootmode & mx28_boot_modes[i].boot_mask;


        if (masked == mx28_boot_modes[i].boot_pads)




for (i = 0; i < ARRAY_SIZE(mxs_boot_modes); i++) {


        masked = bootmode & mxs_boot_modes[i].boot_mask;


        if (masked == mxs_boot_modes[i].boot_pads)



mxs_boot_modes? They're different for mx23 and mx28!
Yes, they're but the structure is the same so we can use same symbol
and have a different mxs_boot_modes matrix for each.
Unless we want a single image for mx233 and mx28. Oh well ... for now
Acked-by: Marek Vasut marex@denx.de
...
...
...
                  break;

  }

[...]
Rest seems fine
Best regards,
Marek Vasut
Best regards,
Marek Vasut

    