Re: [U-Boot] [PATCH 5/8] dfu: tftp: update: Add dfu_write_from_mem_addr() function

Hi Joe,

Hi Lukasz,

On Sun, Jul 12, 2015 at 10:30 AM, Lukasz Majewski l.majewski@majess.pl wrote:

...

This function allows writing via DFU data stored from fixed buffer address (like e.g. loadaddr env variable).

Such predefined buffers are used in the update_tftp() code. In fact this function is a wrapper on the dfu_write() and dfu_flush().

Signed-off-by: Lukasz Majewski l.majewski@majess.pl

drivers/dfu/dfu.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ include/dfu.h | 1 + 2 files changed, 49 insertions(+)

diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c index 332be67..3fbbecc 100644 --- a/drivers/dfu/dfu.c +++ b/drivers/dfu/dfu.c @@ -568,3 +568,51 @@ int dfu_get_alt(char *name)

    return -ENODEV;

}

+/**

• • dfu_write_from_mem_addr - this function adds support for

writing data

• •                       starting from fixed memory address
    

(like $loadaddr)

• •                       to dfu managed medium (e.g. NAND, MMC)
    

• • @param dfu - dfu entity to which we want to store data
• • @param buf - fixed memory addres from where data starts
• • @param size - number of bytes to write
• • @return - 0 on success, other value on failure
• */

+int dfu_write_from_mem_addr(struct dfu_entity *dfu, void *buf, int size) +{

•   unsigned long dfu_buf_size, write;
  

•   int i, ret = 0, left = size;
  

•   void *dp = buf;
  

•   /*
  

•    * Here we must call dfu_get_buf(dfu) first to be sure that
  

dfu_buf_size

•    * has been properly initialized - e.g. if "dfu_bufsiz" has
  

been taken

•    * into account.
  

•    */
  

•   dfu_get_buf(dfu);
  

•   dfu_buf_size = dfu_get_buf_size();
  

•   debug("%s: dfu buf size: %lu\n", __func__, dfu_buf_size);
  

•   for (i = 0; left > 0; i++) {
  

•           write = (dfu_buf_size < left ? dfu_buf_size : left);
  

Please use min() here.

Ok.

...

•           debug("%s: dp: 0x%p left: %d write: %lu\n",
  

__func__,

•                 dp, left, write);
  

•           ret = dfu_write(dfu, dp, write, i);
  

•           if (ret) {
  

•                   error("DFU write failed\n");
  

•                   return ret;
  

•           }
  

•           dp += write;
  

•           left -= write;
  

•   }
  

•   ret = dfu_flush(dfu, NULL, 0, i);
  

•   if (ret)
  

•           error("DFU flush failed!");
  

•   return ret;
  

+} diff --git a/include/dfu.h b/include/dfu.h index adad863..ff4db5d 100644 --- a/include/dfu.h +++ b/include/dfu.h @@ -162,6 +162,7 @@ bool dfu_usb_get_reset(void); int dfu_read(struct dfu_entity *de, void *buf, int size, int blk_seq_num); int dfu_write(struct dfu_entity *de, void *buf, int size, int blk_seq_num); int dfu_flush(struct dfu_entity *de, void *buf, int size, int blk_seq_num); +int dfu_write_from_mem_addr(struct dfu_entity *dfu, void *buf, int size); /* Device specific */ #ifdef CONFIG_DFU_MMC extern int dfu_fill_entity_mmc(struct dfu_entity *dfu, char *devstr, char *s); -- 2.1.4

---

U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Best regards, Lukasz Majewski