In message 20080401075941.145820@gmx.net you wrote:
bugfix: the watchdog post for lwmon5 doesn't work. This Patch fix it. To trigger and activate the watchdog correct it is necessary to create 2 pulses. Lowpegel on GPIO62 point to a voltagefailure.
Please fix English ("correct", "Lowpegel", "voltagefailure").
Is it really 2 pulses - or just one, consisting of
Signed-off-by: Sascha Laue sascha.laue@liebherr.com
...
- if (gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
- if (0 == gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
Please write that as:
if (gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS) == 0) { or if (!gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
* 3.1. GPIO62 is low * Assuming system voltage failure.@@ -99,6 +99,9 @@ int lwmon5_watchdog_post_test(int flags) ints = disable_interrupts (); /* 3.2.2. strobe watchdog once */ WATCHDOG_RESET();
base = post_time_ms (0);while (post_time_ms (base) < 2)WATCHDOG_RESET();
Are you absolutely sure that is needed?
Best regards,
Wolfgang Denk