On 18/09/2012 16:02, Eric Nelson wrote:
Hi Fabio and Stefano,
While trying to understand this, I wonder whether the use of overwrite_console() addresses Wolfgang's original concern.
I think the suggestion was to set the preboot variable to change things:
Wolfgang's first concern was to avoid to hardcode variable inside the code, as it was done in the original mx51 / mx53 code (and not only in i.MX boards).
#define CONFIG_PREBOOT "setenv stdout serial"
This makes sense if you want maintain the possibility that u-boot output is displayed on the LCD. Is this really the case ?
In most cases, we want to display a splashscreen, while the console is still managed by serial line.
If this is the case, adding overwrite_console() tells video subsystem to not change the stdout variable, and then it is not required to set it back to serial neither in code nor with the help of the preboot variable.
The has the benefit of allowing saveenv to completely overwrite the decision.
Am I over-thinking this?
It depends if you want also U-Boot's output on the display or only a picture.
Best regards, Stefano Babic