
11 May
2012
11 May
'12
9:25 p.m.
Dear Michael Walle,
In message 1336671134-16342-4-git-send-email-michael@walle.cc you wrote:
Signed-off-by: Michael Walle michael@walle.cc
How many boards will be using this code?
Eventually this should be made configurable?
- sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
This should generate a warning: too many arguments for format.
Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
In the pitiful, multipage, connection-boxed form to which the flow-
chart has today been elaborated, it has proved to be useless as a
design tool -- programmers draw flowcharts after, not before, writing
the programs they describe. - Fred Brooks, Jr.