Hello Quentin,
On 2024-02-06 11:25, Quentin Schulz wrote:
On 2/6/24 04:56, Dragan Simic wrote:
Prevent the error messages produced by which(1), such as the one quoted below, from being visible in the build outputs.
which: no dtc in (./scripts/dtc)This makes the build outputs look a tiny bit cleaner.
Signed-off-by: Dragan Simic dsimic@manjaro.org
scripts/dtc-version.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/dtc-version.sh b/scripts/dtc-version.sh index 53ff868bcdce..6d3d7b68fdfa 100755 --- a/scripts/dtc-version.sh +++ b/scripts/dtc-version.sh @@ -15,7 +15,7 @@ if [ ${#dtc} -eq 0 ]; then exit 1 fi
-if ! which $dtc >/dev/null ; then +if ! which $dtc >/dev/null 2>/dev/null ; then
What about
which $dtc > /dev/null 2>&1
instead?
That's exactly what I intended to use, but IIRC some shells or some older versions of some shells may not recognize that, so I went with a more verbose, but slightly safer option.
Reviewed-by: Quentin Schulz quentin.schulz@theobroma-systems.com
Thanks for your review.