Dear Dirk Eibach,
In message 1229419373-5217-1-git-send-email-eibach@gdsys.de you wrote:
The iteration limit is passed to mtest as a fourth parameter: [start [end [pattern [iterations]]]] If no fourth parameter is supplied, there is no iteration limit and the test will loop forever.
Signed-off-by: Dirk Eibach eibach@gdsys.de
- Beautified commit message
- Whitespace cleanup
Actually a whitespace messup, I'm afraid.
#ifdef CMD_MEM_DEBUG -#define PRINTF(fmt,args...) printf (fmt ,##args) +#define PRINTF(fmt, args...) printf(fmt, ##args)
Please do not do this, it causes incompatible behaviour for different versions of GCC.
From the GCC info pages:
Previous versions of CPP implemented the comma-deletion extension much more generally. We have restricted it in this release to minimize the differences from C99. To get the same effect with both this and previous versions of GCC, the token preceding the special `##' must be a comma, and there must be ^^^^^^^^^^^^^ white space between that comma and whatever comes immediately ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ before it: ^^^^^^^^^^
#define eprintf(format, args...) fprintf (stderr, format , ##args)
So the white space before the comma is actually intentional and essential. Do not remove it.
Also, please never mix actual changes and such "cleanup" into one patch. If you think a cleanup is necessary, then split it into a sepparate patch.
Best regards,
Wolfgang Denk