On Fri, Mar 19, 2021 at 12:26 AM Peng Fan (OSS) peng.fan@oss.nxp.com wrote:
From: Ye Li ye.li@nxp.com
Update LPDDR4 script to sync with v2020.04 u-boot
Signed-off-by: Ye Li ye.li@nxp.com
Peng,
The commit log does not make sense. I believe you want to say something like 'Update LPDDR4 script to sync with <xyz> version of the NXP MX8M_DDR_tool'.
board/freescale/imx8mm_evk/lpddr4_timing.c | 692 +++++++++------------ 1 file changed, 280 insertions(+), 412 deletions(-)
diff --git a/board/freescale/imx8mm_evk/lpddr4_timing.c b/board/freescale/imx8mm_evk/lpddr4_timing.c index 8e48b9d81b..4373ca624e 100644 --- a/board/freescale/imx8mm_evk/lpddr4_timing.c +++ b/board/freescale/imx8mm_evk/lpddr4_timing.c @@ -1,129 +1,162 @@ // SPDX-License-Identifier: GPL-2.0+ /*
- Copyright 2019 NXP
- Copyright 2018-2019 NXP
*/
- Generated code from MX8M_DDR_tool
I understand that this file is a direct output of the NXP MX8M_DDR tool but it would be nice to see you add to the comment above what version of the tool you used to produce this what functional differences it makes. If you knew what version of the tool produced the original file one could compare versions.
As I am the maintainer of an IMX8M Mini board also, I try to pay attention to NXP's updates to the DDR timing config files to let me know if something important has changed.
Best Regards,
Tim