On Mon, Apr 22, 2019 at 11:50:22PM +0300, Vladimir Zapolskiy wrote:
Hi Jagan, Tom,
On 04/19/2019 09:48 AM, Jagan Teki wrote:
Dropped
- lpc32xx_ssp driver
- CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items
Dropped due to:
- no active updates
- no dm conversion
- multiple pings for asking dm-conversion
I really don't want to rush into moaning, however let me ask you to drop the reason given above as invalid, otherwise please clarify who were the addressees of these 'multiple pings'.
Indeed. Since it was only last month or so that I setup a low-traffic list for maintainers / custodians for important issues like this, and lots of previous series have been super bad about Cc'ing the right people, it's not appropriate to say "no one has spoken up" or similar lack of reply arguments. I know there's been previous postings of "delete this (and all of the other SPI drivers, and all of the other boards and deletion posts too)" type series but no, they've often not gone out to the right people.
- no response for dm converted patch
I believe there was no DM conversion patch for this particular driver, could it happen that I've missed it?
There was, but all of what I said above about Cc applies too: https://patchwork.ozlabs.org/patch/910751/
- driver-model migration expiry
Definitely this is a valid reason.
The good news is that I don't have any strong objection against the deletion of the driver.
Why? Recently Quentin Schulz added drivers/spi/pl022_spi.c, and it provides a support of right the same SPI controller, the new driver satisfies DM policy.
Quentin, you may take a look at drivers/spi/lpc32xx_ssp.c before (or after though) its removal for scavenging any goodies.
From my side I'd like to test the new driver on one of my boards, but unfortunately it may take indefinite time, because it will require some tinkering. Nevertheless, if any LPC32xx specific changes will be required, they'll be added to the new Quentin's driver.
In the end, that sounds like an overall improvement to the situation, even if I'm not happy with how we're getting there. Sorry about the frustration (everyone) here.