Re: [U-Boot] [PATCH 4/8] net/tftp.c: cosmetic: do not use assignment in if condition

Dear Luca Ceresoli,

In message 1305388203-22983-5-git-send-email-luca.ceresoli@comelit.it you wrote:

This removes the following checkpatch issue:

• ERROR: do not use assignment in if condition.

There is one such error left:

ERROR: do not use assignment in if condition #239: FILE: tftp.c:239:

• if (!ProhibitMcast
  

•  && (Bitmap = malloc(Mapsize))
  

•  && eth_get_dev()->mcast) {
  
  

which would require an additional nested if to be fixed, resulting in longer and less readable code.

Signed-off-by: Luca Ceresoli luca.ceresoli@comelit.it Cc: Wolfgang Denk wd@denx.de

---

net/tftp.c | 18 ++++++++++++------ 1 files changed, 12 insertions(+), 6 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk