Re: [U-Boot-Users] [PATCH] [RFC] Add Device tree support to lite5200b eval board

In message 11617655783887-git-send-email-grant.likely@secretlab.ca you wrote:

Please comment on this patch. This is not the final patch as applying this one prevents booting an arch/ppc kernel (due to adding CONFIG_OF_FLAT_TREE to include/configs/IceCube.h).

I have not yet successfully booted an arch/powerpc kernel using this change, but I want feedback to ensure I've twiddled the correct bits. :)

I can just comment on formal things.

• p = ft_get_prop(blob, "/cpus/" OF_CPU "/bus-frequency", &len);
• if (p != NULL)

• *p = cpu_to_be32(clock);
  

• p = ft_get_prop(blob, "/" OF_SOC "/serial@2000/clock-frequency", &len);
• if (p != NULL)

• *p = cpu_to_be32(clock);
  

• p = ft_get_prop(blob, "/" OF_SOC "/serial@2200/clock-frequency", &len);
• if (p != NULL)

• *p = cpu_to_be32(clock);
  

• p = ft_get_prop(blob, "/" OF_SOC "/serial@2400/clock-frequency", &len);
• if (p != NULL)

• *p = cpu_to_be32(clock);
  

• p = ft_get_prop(blob, "/" OF_SOC "/serial@2600/clock-frequency", &len);
• if (p != NULL)

• *p = cpu_to_be32(clock);
  

• p = ft_get_prop(blob, "/" OF_SOC "/serial@2800/clock-frequency", &len);
• if (p != NULL)

• *p = cpu_to_be32(clock);
  

• p = ft_get_prop(blob, "/" OF_SOC "/serial@2c00/clock-frequency", &len);
• if (p != NULL)

• *p = cpu_to_be32(clock);
  

Please write this as a loop.

Best regards,

Wolfgang Denk