Re: [U-Boot] [PATCH v3] arm:goni:mmc: Add sd card detection and initialization.

On 10/09/13 19:28, Jaehoon Chung wrote:

Looks good to me.

Acked-by: Jaehoon Chung jh80.chung@samsung.com

On 09/10/2013 06:34 PM, Przemyslaw Marczak wrote:

...

This change allow to use sd card on Goni the same like mmc 0. SD card is mmc dev 1, so it can be used like this: "fatls mmc 1:2". SD card is inited even if eMMC initialization fails.

Signed-off-by: Przemyslaw Marczak p.marczak@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com CC: Minkyu Kang mk7.kang@samsung.com

---

Changes for v2:

• add ret_sd for sd card initialization errors
• return bit OR of ret and ret_sd values

Changes for v3:

• change puts() to error() when prints error message
• chance BIT OR on ret and sd_ret to BIT AND

Now return value is 0 if any card will init succeed and -1 if both fails.

---

board/samsung/goni/goni.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-)

applied to u-boot-samsung.

Thanks, Minkyu Kang.