Re: [U-Boot] [PATCH] imx51:Add support basic boot code of freescale imx51 bbg board

Dear Fred Fan,

In message 2f495dc80912010844h6b4aa1e4i4588f808384b6272@mail.gmail.com you wrote:

I almost fixed all of your comments.

By some of them I can not fix them now.

1. Copyright block. It defined freescale other team. I can not change them

directly.

I see. We will have to wait for this change, then.

2. iomux module can not use C structure to access registers. Because

register has encoded in to pin definition.

I don't understand this statement. Why do you think this cannot be done with C structs and I/O accessors?

When I tested the new code on target board, I will send out to review again.

I'm looking forward to get this mainlined, but please fix all issues first. Thanks.

Best regards,

Wolfgang Denk