Re: [PATCH 4/5] firmware: scmi: add configs to select the supported agents

Hello Patrick,

Acked-by: Etienne Carriere etienne.carriere@linaro.org for the series with typo fixed in patch 4/5 (see below).

On Thu, 28 Oct 2021 at 15:01, Patrick Delaunay patrick.delaunay@foss.st.com wrote:

Add two configs CONFIG_SCMI_AGENT_MAILBOX and CONFIG_SCMI_AGENT_SMCCC to select the supported agents as all the agents are not supported.

Signed-off-by: Patrick Delaunay patrick.delaunay@foss.st.com

drivers/firmware/scmi/Kconfig | 16 ++++++++++++++++ drivers/firmware/scmi/Makefile | 4 ++-- 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/scmi/Kconfig b/drivers/firmware/scmi/Kconfig index c3a109beac..db35438dda 100644 --- a/drivers/firmware/scmi/Kconfig +++ b/drivers/firmware/scmi/Kconfig @@ -17,3 +17,19 @@ config SCMI_FIRMWARE based on message exchange. Messages can be exchange over tranport channels as a mailbox device or an Arm SMCCC service with some piece of identified shared memory.

+config SCMI_AGENT_MAILBOX

•   bool "Enable SCMI agent mailbox"
  

•   depends on SCMI_FIRMWARE && DM_MAILBOX
  

•   default y
  

•   help
  

•     Enable the SCMI communication channel based on mailbox
  

•     for compatible "arm,scmi".
  

+config SCMI_AGENT_SMCCC

•   bool "Enable SCMI agent SMCCC"
  

•   depends on SCMI_FIRMWARE && ARM_SMCCC
  

•   default y
  

•   help
  

•     Enable the SCMI communication channel based on Arm SMCCC service for
  

•     compatibble "arm,scmi-smc".
  

s/compatibble/compatible/

regards, etienne

diff --git a/drivers/firmware/scmi/Makefile b/drivers/firmware/scmi/Makefile index 966475ec10..d6d6f89493 100644 --- a/drivers/firmware/scmi/Makefile +++ b/drivers/firmware/scmi/Makefile @@ -1,5 +1,5 @@ obj-y += scmi_agent-uclass.o obj-y += smt.o -obj-$(CONFIG_ARM_SMCCC) += smccc_agent.o -obj-$(CONFIG_DM_MAILBOX) += mailbox_agent.o +obj-$(SCMI_AGENT_SMCCC) += smccc_agent.o +obj-$(SCMI_AGENT_MAILBOX) += mailbox_agent.o obj-$(CONFIG_SANDBOX) += sandbox-scmi_agent.o sandbox-scmi_devices.o -- 2.25.1