Hello
+#define CLCD_LBAS 0x00000014
CLCD_LBAS isn't used in the code, please remove it.
I disagree for two reasons: the register exists in the logic block, and the code is copied from a linux header (as noted in the file itself).
Since the clcd block is not something designed for the nomadik but the standard primecell, I don't think trimming its definition is useful; other boards can benefit from the header being complete.
+/* u-boot specific: cooked information (not used at this point) */ +struct clcd_params {
- int left_margin, right_margin, upper_margin, lower_margin;
- int hsync_len, vsync_len;
- int sync, vmode;
+};
this is also not used, please do not add unused code.
I planned to used it, and this is the complete information that's needed, and I plan to implement it sooner or later. Nonetheless, I understand your request to remove it and I have no problems here.
I couldn't comment on this in the first patch version, sorry.
Ok, no problem.
/alessandro