Siddharth Vadapalli s-vadapalli@ti.com writes:
On Mon, Nov 25, 2024 at 07:51:54PM -0600, Jon Humphreys wrote:
Hello Jon,
[...]
Hi Siddharth, this is an issue that I also discovered while working on a separate issue with Collabora, but haven't posted a patch yet. The issue is that when DFU booting, spl_dfu_cmd() will setup it's own value for dfu_alt_info before calling run_dfu(). In our existing code, however, this will get overridden by set_dfu_alt_info(). This issue isn't specific to TI boards.
Can you try this patch to drivers/dfu/dfu.c to see if it solves the problems you are seeing:
@@ -153,10 +153,11 @@ int dfu_init_env_entities(char *interface, char *devstr)
dfu_reinit_needed = false;
- str_env = env_get("dfu_alt_info");
#ifdef CONFIG_SET_DFU_ALT_INFO
- set_dfu_alt_info(interface, devstr);
- if (!str_env) {
- set_dfu_alt_info(interface, devstr);
- str_env = env_get("dfu_alt_info");
- }
#endif
- str_env = env_get("dfu_alt_info"); if (!str_env) { pr_err(""dfu_alt_info" env variable not defined!\n"); return -EINVAL;
Yes, this patch fixes the issue. Do you plan to post this patch? Or has it already been posted and is under discussion? Please let me know.
no patch posted yet, but I will do that next week.
Jon
Regards, Siddharth.