-----Original Message----- From: Holger Brunck [mailto:holger.brunck@keymile.com] Sent: 12 June 2012 14:04 To: Prafulla Wadaskar Cc: Valentin Longchamp; prafulla@mavell.com; u-boot@lists.denx.de; Gerlando Falauto Subject: Re: [PATCH 04/20] arm/km: add kmnusa board support
On 06/12/2012 06:39 AM, Prafulla Wadaskar wrote:
-----Original Message----- From: Valentin Longchamp [mailto:valentin.longchamp@keymile.com] Sent: 07 June 2012 15:37 To: prafulla@mavell.com Cc: Holger Brunck; u-boot@lists.denx.de; Valentin Longchamp;
Gerlando
Falauto; Prafulla Wadaskar Subject: [PATCH 04/20] arm/km: add kmnusa board support
From: Holger Brunck holger.brunck@keymile.com
This board is similar to portl2, but it has the u-boot environment in a SPI NOR flash and not in an i2c eeprom like portl2 have.
Some other details:
- IVM EEPROM is at adress: pca9547:70:9
- PCI is enabled
- PIGGY4 is connected via MV88E6352 simple switch. There is no phy between the simple switch and the kirkwood.
Signed-off-by: Holger Brunck holger.brunck@keymile.com Signed-off-by: Valentin Longchamp valentin.longchamp@keymile.com cc: Gerlando Falauto gerlando.falauto@keymile.com cc: Prafulla Wadaskar prafulla@marvell.com
MAINTAINERS | 1 + board/keymile/km_arm/128M16-1.cfg | 294 +++++++++++++++++++++++++++++++++++++
Please avoid file names starting with numbers.
would sdram128M16-1.cfg be ok? The reason for this numbering is to have a chance to know which organisation this RAM has.
board/keymile/km_arm/km_arm.c | 9 +- boards.cfg | 1 + include/configs/km/km_arm.h | 44 +++++- include/configs/km_kirkwood.h | 67 +++++++-- 6 files changed, 392 insertions(+), 24 deletions(-) create mode 100644 board/keymile/km_arm/128M16-1.cfg
diff --git a/MAINTAINERS b/MAINTAINERS index 0445539..aa11268 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -738,6 +738,7 @@ Sergey Lapin slapin@ossfans.org Valentin Longchamp valentin.longchamp@keymile.com
km_kirkwood ARM926EJS (Kirkwood SoC)
kmnusa ARM926EJS (Kirkwood SoC)Again.... I would like to suggest to separate out new boards
addition, bugfixes/updates specific to km_*boards and generic kirkwood specific patches.
It's always faster to merger small patch series that big one.
Yes ok, but was has this to do with this patch? What is meant to be kirkwood specific? This is all board related code.
I agree, let's separate out - 1. bugfix/updates patch series to current code 2. "Kirkwood specific" means the changes to the Kirkwood related file that may affects other boards, for ex arch/arm/cpu/arm926ejs/mach-kirkwood/* 3. Additional board supports
And if possible these patches should be independent so that can be pulled independently
Regards. Prafulla . . .