Re: [U-Boot] [PATCH 2/3] board/tqm85xx: Clean up PPC_DDR_WIMGE define logic in config file

Dear Becky Bruce,

In message 13107687401917-git-send-email-beckyb@kernel.crashing.org you wrote:

The way I wrote this in the first time was based on the original code, but I used a karnaugh map to make it a bit easier to read..... There should be no functional change.

Ummm...

#if defined(CONFIG_TQM_BIGFLASH) || \

• (!defined(CONFIG_TQM8548_AG) && !defined(CONFIG_TQM8548_BE))

• defined(CONFIG_TQM8548_AG) || \
• defined(CONFIG_TQM8548_BE)

Sorry, but this looks wrong to me.

Isn't the rule "foo & bar == !(!foo || !bar)", so that

(!defined(CONFIG_TQM8548_AG) && !defined(CONFIG_TQM8548_BE))

becomes

!(defined(CONFIG_TQM8548_AG) || defined(CONFIG_TQM8548_BE))

?

I think you are missing the "not" part...

Best regards,

Wolfgang Denk