Re: [U-Boot] [PATCH v2 3/3] imx:mx6 set normal APS and standby PFM mode

On Thu, Jan 15, 2015 at 8:18 AM, Peng Fan Peng.Fan@freescale.com wrote:

@@ -515,11 +516,16 @@ int board_spi_cs_gpio(unsigned bus, unsigned cs) int power_init_board(void) { struct pmic *p;

•   unsigned int ret;
  
    p = pfuze_common_init(I2C_PMIC);
    if (!p)
            return -ENODEV;
  
  

•   ret = pfuze_mode_init(p, APS_PFM);
  

•   if (ret < 0)
  

•           return -EIO;
  

You should return 'ret' here instead.

•   return 0;
  

}

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c index 2f7198d..59544d9 100644 --- a/board/freescale/mx6sabresd/mx6sabresd.c +++ b/board/freescale/mx6sabresd/mx6sabresd.c @@ -631,12 +631,16 @@ int board_init(void) int power_init_board(void) { struct pmic *p;

•   unsigned int reg;
  

•   unsigned int reg, ret;
  
    p = pfuze_common_init(I2C_PMIC);
    if (!p)
            return -ENODEV;
  
  

•   ret = pfuze_mode_init(p, APS_PFM);
  

•   if (ret < 0)
  

•           return -EIO;
  

Same here.

•   /* Increase VGEN3 from 2.5 to 2.8V */
    pmic_reg_read(p, PFUZE100_VGEN3VOL, &reg);
    reg &= ~LDO_VOL_MASK;
  

diff --git a/board/freescale/mx6sxsabresd/mx6sxsabresd.c b/board/freescale/mx6sxsabresd/mx6sxsabresd.c index 5cc58ac..fbf3337 100644 --- a/board/freescale/mx6sxsabresd/mx6sxsabresd.c +++ b/board/freescale/mx6sxsabresd/mx6sxsabresd.c @@ -199,12 +199,16 @@ static struct i2c_pads_info i2c_pad_info1 = { int power_init_board(void) { struct pmic *p;

•   unsigned int reg;
  

•   unsigned int reg, ret;
  
    p = pfuze_common_init(I2C_PMIC);
    if (!p)
            return -ENODEV;
  
  

•   ret = pfuze_mode_init(p, APS_PFM);
  

•   if (ret < 0)
  

•           return -EIO;
  

Same here.