
1 Jul
2011
1 Jul
'11
2:43 p.m.
Kumar Gala wrote:
Erratum SERDES-8 says that the clocks for bank 3 needs to be enabled if bank 2 is enabled, but this was not being done for SERDES protocols 0xF and 0x10. The bank reset that was being done for erratum SERDES4 (a left-over work-around that was removed in "powerpc/85xx: remove SERDES4 soft-reset work-around") also happened to enable bank 3 (apparently an undocumented feature). Now that the reset has been removed, bank 3 was not being enabled for these two SERDES protocols.
Kumar, these two patches should be merged, since the first one breaks SERDES, and this one fixes the problem that the first one exposes. If you add them as separate commits, then you'll break git-bisect.
--
Timur Tabi
Linux kernel developer at Freescale