On Fri, Jun 14, 2013 at 6:39 PM, Axel Lin axel.lin@ingics.com wrote:
2013/6/14 Jagan Teki jagannadh.teki@gmail.com:
Hi,
IMHO: Can you please use the proper commit header prefix.
I am just sharing my thoughts, ignore this if you know it already. I followed below syntax. "<main_module>: <sub_module>: <sub_sub_module>: <COMMIT_HEADER>"
Ex: for this commit (seems like this commit changes two drivers) spi: cf_qspi | mxc_spi: Use DIV_ROUND_UP at appropriate places
This does not scale. What if a (trivial) patch touches 10 drivers?
Yes, you are correct if the changes is common to across the all drivers or If the changes which are more in 10 spi drivers out of 20 or > 10 for your example - use "spi: " and I think it's good to use above syntax as you changesd two drivers.
I am just showing the possibilities of using the coding guidelines, nothing more.
-- Thanks, Jagan.