On Mon, 12 Nov 2018 12:41:15 +0530 Jagan Teki jagan@amarulasolutions.com wrote:
On Mon, Nov 12, 2018 at 12:15 PM Boris Brezillon boris.brezillon@bootlin.com wrote:
Hi Jagan,
On Mon, 12 Nov 2018 10:13:40 +0530 Jagan Teki jagan@amarulasolutions.com wrote:
On Sat, Nov 10, 2018 at 4:52 PM Boris Brezillon boris.brezillon@bootlin.com wrote:
dfu_fill_entity_nand() uses find_dev_and_part() and mtdparts_init() which are provided by cmd/mtdparts.c.
Add the dependency to avoid build failures when CMD_MTDPARTS is not selected.
Reported-by: Jagan Teki jagan@amarulasolutions.com Fixes: 6828e602b722d ("dfu: Migrate to Kconfig") Signed-off-by: Boris Brezillon boris.brezillon@bootlin.com
drivers/dfu/Kconfig | 1 + 1 file changed, 1 insertion(+)
Squashed both patches into "cmd: ubi: Remove useless call to mtdparts_init()" patch.
Sorry to complain again, but I don't think this was the right thing to do. Those 2 patches are unrelated to "cmd: ubi: Remove useless call to ->mtdparts_init()", it's just that this commit uncovers problems in the dependency definition of the DFU_NAND and MTD{PARTS,IDS}_DEFAULT options.
If you want to keep things bisectable, it would be preferable to move those 2 commits before "cmd: ubi: Remove useless call to ->mtdparts_init()" (and rework the commit messages accordingly).
I was concentrated to move this on the release, anyway please send the series again will push it during MW.
Is it too late to queue it for the current release (I see v2018.11 has not been tagged yet)?