Dear Martha M Stan,
In message 12525956202930-git-send-email-mmarx@silicontkx.com you wrote:
From: Martha Marx mmarx@silicontkx.com
May I ask what the purpose of such a rename is? I mean, which problem are you tryin to fix, and in which way is the new code supposed to be better than the old one?
Actually I think the new names are much worse. What's the purpose of omitting the "CONFIG_SYS_" part?
...
out_be32(&im->mddrc.ddr_command, CONFIG_SYS_MICRON_NOP);
out_be32(&im->mddrc.ddr_command, DDR_NOP);
For example this rename - using "DDR_NOP" for a configurable parameter in a global file, and having to #define this in the board config files makes no sense to me.
We have standard rule about naming of configration options. This here is clearly a case where "CONFIG_SYS_" applies.
All the other renames fall in the same category.
Unless you have a very good reason for this rename I tend to NAK this.
Best regards,
Wolfgang Denk