Matthias Kaehlcke wrote:
hi tom,
thanks for your review!
El Sun, Jan 17, 2010 at 09:25:52AM -0600 Tom ha dit:
Matthias Kaehlcke wrote:
Add support for the Cirrus EP93XX platform
<snip>
create mode 100644 include/asm-arm/arch-ep93xx/ep93xx.h
There are build errors that cut this review short. The review of this patch is fairly complete. I will review the others on the next revision.
For the ep93xx boards, I saw this error on MAKEALL and building normally
src/u-boot-arm/drivers/net/ep93xx.c:513: undefined reference to `unlikely' drivers/net/libnet.a(ep93xx.o): In function `ep93xx_miiphy_write'
i forgot that i have an additional patch in my tree that fixes this issue
as it isn't related with ep93xx in any way i sent it separately:
http://lists.denx.de/pipermail/u-boot/2009-December/065779.html
I verified that unlikely/likely are defined in linux/compiler.h As recommended by Mike F.
what is the right way to solve this dependency on a patch that isn't in mainline yet? add it to the patch set though it isn't ep93xx related?
I see your point. That change would likely fix this issue.
Include this fix in your next revision if it hasn't been accepted into the mainline. I will not be able to ack it but at least it would not hold up the review. The ack-ing would be done, i believe, by the flash-nand custodian, Scott W or Wolfgang.
Tom