-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 24.11.2014 23:20, Tom Rini wrote:
ok I'll send an updated patch.
Thanks - and as I mentioned it seems wrong to write to a word above the top of the stack.
I discard this patch. The only requirement for the stack pointer on MIPS is alignment on a 8 Byte boundary. reserve_stacks already aligns it to 16 Byte (gd->start_addr_sp &= ~0xf;).
To make stack walking and backtraces working flawlessy in gdb, I found another solution [1].
And I of course missed this email while sorting out other problems with stuff I was applying. I'll just back this out and take the better fix.
hm, the patch landed in v2015.01-rc2. Do you want to create a revert patch or shall I include one in my next pull request?
- -- - - Daniel